Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: order of API paths in proto for AssignMultipleGroups #8080

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

mapmeld
Copy link
Contributor

@mapmeld mapmeld commented Oct 4, 2023

Description

Calls to PATCH /api/v1/users/assignments, added in #7971 , are failing because it was defined in the proto after /api/v1/users/{user_id}

Test Plan

Explains error on latest-main: type mismatch, parameter: user_id, error: strconv.ParseInt: parsing \"assignments\": invalid syntax

URL is not conflicted by any other definitions in api.proto

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit bba92de
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/651df0882e48b9000828b73b

@mapmeld mapmeld enabled auto-merge (squash) October 4, 2023 23:26
@mapmeld mapmeld merged commit 8073a2d into main Oct 4, 2023
71 of 86 checks passed
@mapmeld mapmeld deleted the apiOrder branch October 4, 2023 23:31
@dannysauer dannysauer added this to the 0.26.2 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants