fix: Empty / NotEmpty operators for descriptions, tags [WEB-1751] #8090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapmeld
added
the
to-cherry-pick
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stoksc
reviewed
Oct 6, 2023
master/internal/experiment_filter.go
Outdated
Comment on lines
365
to
366
| queryString = "? ? OR ? ? ? OR ? ? ?" | ||
| queryArgs = append(queryArgs, bun.Safe(col), bun.Safe(oSQL)) |
There was a problem hiding this comment.
once you are in this empty case, just writing out the fragment is significantly more readable to me
Suggested change
| queryString = "? ? OR ? ? ? OR ? ? ?" | |
| queryArgs = append(queryArgs, bun.Safe(col), bun.Safe(oSQL)) | |
| queryString = "? IS NULL OR ? = "" OR ? = []" | |
| queryArgs = append(queryArgs, bun.Safe(col), bun.Safe(col), bun.Safe(col)) |
There was a problem hiding this comment.
i know that goes against what is happening here already, so i'm not blocking, just giving my 2c.
There was a problem hiding this comment.
this does look a lot neater ✅
stoksc
approved these changes
Oct 6, 2023
stoksc
reviewed
Oct 6, 2023
master/internal/experiment_filter.go
Outdated
| case empty: | ||
| queryString = "? ? OR ? ? ? OR ? ? ?" | ||
| queryArgs = append(queryArgs, bun.Safe(col), bun.Safe(oSQL)) | ||
| queryArgs = append(queryArgs, bun.Safe(col), bun.Safe(equal), "") |
There was a problem hiding this comment.
total nit, it looks like equal and notEqual are used to match on the input format, so using them in the output query is maybe unintended coupling
Suggested change
| queryArgs = append(queryArgs, bun.Safe(col), bun.Safe(equal), "") | |
| queryArgs = append(queryArgs, bun.Safe(col), bun.Safe(equal), "") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The experiment filters for empty / not-empty were queries for NULL / IS NOT NULL
For description we should also consider an empty string
For tags we should consider the string "[]" to be empty
Test Plan
Filter a project's experiments by description empty / is not empty
Filter a project's experiments by tags empty / is not empty
Checklist
docs/release-notes/.See Release Note for details.