fix: ignore last_auth_at to update modified_at on users table
#8091
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| DROP TRIGGER IF EXISTS autoupdate_users_modified_at ON users; | ||
|
|
||
| CREATE TRIGGER autoupdate_users_modified_at | ||
| BEFORE INSERT OR UPDATE OF password_hash, admin, active, display_name, remote ON public.users |
There was a problem hiding this comment.
I need to list columns. Are there better way to trigger function? I couldn't find except or ignore specific column option in postgres trigger
There was a problem hiding this comment.
yeah, it'd be great if we could do it the other way around. As is if we add a column it would be easy to miss to add it here.
| DROP TRIGGER IF EXISTS autoupdate_users_modified_at ON users; | ||
|
|
||
| CREATE TRIGGER autoupdate_users_modified_at | ||
| BEFORE INSERT OR UPDATE OF password_hash, admin, active, display_name, remote ON public.users |
There was a problem hiding this comment.
yeah, it'd be great if we could do it the other way around. As is if we add a column it would be easy to miss to add it here.
keita-determined
added
the
to-cherry-pick
my stance on this has always been no. but i could see an argument you would want to, just incase the bug fix is worse than the bug, and you need to revert it. |
|
either way is fine, tbh, given the frequency at which folks use down migrations. |
|
OK. I'll go with the current state then |
) (cherry picked from commit 5483d12)
Description
fix for https://github.com/determined-ai/release-party-issues/issues/786#issuecomment-1749503941
When
last_auth_atis updated, trigger should ignore the changeTest Plan
modified_atcolumn is updated only when one or more ofpassword_hash,admin,active,display_name,remotecolumn(s) are changed.Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket