refactor: update UI Kit Icon component [WEB-1699] #8122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilyBonar
requested review from
ClaireNeveu,
alexjdetermined and
johnkim-det
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
EmilyBonar
changed the title
EmilyBonar
commented
Oct 11, 2023
Comment on lines
+377
to
+378
| backgroundColor="white" // only gets applied for scheduled and queued states | ||
| opacity={0.25} // only gets applied for scheduled and queued states |
There was a problem hiding this comment.
I couldn't figure out how to get the Queued animation to look right without these styles, but if anyone else has an idea please let me know.
EmilyBonar
force-pushed
the
emilybonar/update-icon
branch
from
52dd53e
to
fdf7b98
Compare
johnkim-det
approved these changes
Oct 12, 2023
EmilyBonar
force-pushed
the
emilybonar/update-icon
branch
from
03fa8dc
to
1cdbe89
Compare
ClaireNeveu
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Note: The ticket calls for our Logo component to be merged into Icon. I haven't done that yet because Logo has dependencies on our determinedInfo store and handles light vs dark theming and sizing differently than the rest of the icons.
Test Plan
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket