Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Apply style guide edits #8134

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

tara-det-ai
Copy link
Member

Apply minor edits

@tara-det-ai tara-det-ai requested a review from a team as a code owner October 12, 2023 16:52
@cla-bot cla-bot bot added the cla-signed label Oct 12, 2023
@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 4126ae6
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/652832f6ddf37a00084d1747

@determined-ci determined-ci added the documentation Improvements or additions to documentation label Oct 12, 2023
docs/release-notes/k8s-context-size-limit.rst Outdated Show resolved Hide resolved
@@ -3,7 +3,7 @@
#######

.. meta::
:description: Get links to info about Determined AI tools such as the CLI User Guide, Commands and Shells, WebUI, Jupyter Notebooks, TensorBoard, and Exposing Custom Ports.
:description: Get links to info about Determined tools such as the CLI User Guide, Commands and Shells, WebUI, Jupyter Notebooks, TensorBoard, and Exposing Custom Ports.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalization, for a start:

Suggested change
:description: Get links to info about Determined tools such as the CLI User Guide, Commands and Shells, WebUI, Jupyter Notebooks, TensorBoard, and Exposing Custom Ports.
:description: Get links to info about Determined tools such as the CLI user guide, commands and shells, WebUI, Jupyter Notebooks, TensorBoard, and exposing custom ports.

Though, going further, this is kind of weirdly phrased and I don't know if it really needs to just list out every single link on this page, so maybe change it entirely to this instead:

Suggested change
:description: Get links to info about Determined tools such as the CLI User Guide, Commands and Shells, WebUI, Jupyter Notebooks, TensorBoard, and Exposing Custom Ports.
:description: Get links to info about the different interfaces that can be used to interact with Determined.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, cool, i've added this change to #8100

@determined-ci determined-ci requested a review from a team October 12, 2023 17:52
@tara-det-ai tara-det-ai merged commit f52f7c6 into main Oct 12, 2023
70 of 84 checks passed
@tara-det-ai tara-det-ai deleted the docs/Apply-style-guide-edits branch October 12, 2023 18:31
@dannysauer dannysauer added this to the 0.26.2 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants