Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Theme dropped after page refreshing #8139

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: Theme dropped after page refreshing #8139

merged 1 commit into from
Oct 16, 2023

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented Oct 12, 2023

Description

Fix the issue that the theme selection is not persistent.
As soon as the page refreshes or reloads, it defaults to system settings.
This is because SettingsProvider and UIProvider were not properly wrapped.

Test Plan

Change system mode to light, then at the WebUI, switch the mode to Dark, refresh page, the theme should persist.
Change system mode to dark, then at the WebUI, switch the mode to Light, refresh page, the theme should persist.
Start server with RBAC, at the login page, HPE logo should be visible.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

WEB-1756

@gt2345 gt2345 requested a review from a team as a code owner October 12, 2023 21:09
@cla-bot cla-bot bot added the cla-signed label Oct 12, 2023
@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit e9d31c6
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/652860721323e100088b790e
😎 Deploy Preview https://deploy-preview-8139--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gt2345 gt2345 requested review from thiagodallacqua-hpe and EmilyBonar and removed request for thiagodallacqua-hpe October 13, 2023 17:23
Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gt2345 gt2345 merged commit 88d9533 into main Oct 16, 2023
73 of 87 checks passed
@gt2345 gt2345 deleted the gt/1756-fix-theme branch October 16, 2023 16:38
@dannysauer dannysauer added this to the 0.26.2 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants