chore(actors): refactor pods.go without actors [DET-9901] #8170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
stoksc
changed the title
stoksc
force-pushed
the
refactor-pods-oss
branch
2 times, most recently
from
2e1d454
to
d531854
Compare
stoksc
force-pushed
the
refactor-pods-oss
branch
from
d531854
to
06615db
Compare
erikwilson
reviewed
Oct 17, 2023
| @@ -615,13 +602,13 @@ func (p *pods) refreshPodStates(ctx *actor.Context, allocationID model.Allocatio | |||
| continue | |||
| } | |||
| pod := pod | |||
| p.podStatusCallback(ctx.Self().System(), watch.Event{Object: &pod}) | |||
| p.podStatusCallback(system, watch.Event{Object: &pod}) | |||
There was a problem hiding this comment.
Would it be possible to completely remove actors from pods if we can resolve this? Maybe passing in a callback or interface to Initialize?
There was a problem hiding this comment.
I'm going to fix this when i do k8s resource pool. felt it would be easier then.
There was a problem hiding this comment.
at that point, i won't be able to ctx.Tell the cluster anyway, so it will have to happen.
erikwilson
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change pods.go from an actor to a plain Go struct with locks and make all calls synchronous. The change is simple; most of the work is in making sure this causes no bugs like deadlocks or race conditions, and no performance issues due to lock contention.
Test Plan
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket
DET-9901