-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update group table #8194
feat: update group table #8194
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ticket mentioned about users should be alphabetically sorted, not sure if that's implemented
Good catch. I forgot to implement it. Will fix it soon |
ee81b62
to
d02d281
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8f730c1
to
ff66c69
Compare
Description
WEB-1739
Test Plan
In Groups tab
Check if menu item label from “Edit” to “Edit Group”
Check if menu item label from “Delete” to “Delete Group”
Check if menu item color for “Delete Group” to destructive action red
Check if group level column header copy from “Users” to “Members”
Check if using nameplate layout table to be one “User” column that matches the nameplate style formatting of the user column in the “Users” tab table. with alpha sort
Add confirmation alert for “Remove user from group”
Commentary (optional)
cannot find easy solution
Checklist
docs/release-notes/
.See Release Note for details.
Ticket