Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update group table #8194

Merged
merged 3 commits into from
Oct 20, 2023
Merged

feat: update group table #8194

merged 3 commits into from
Oct 20, 2023

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Oct 18, 2023

Description

WEB-1739

Test Plan

In Groups tab

Check if menu item label from “Edit” to “Edit Group”
Check if menu item label from “Delete” to “Delete Group”
Check if menu item color for “Delete Group” to destructive action red

Check if group level column header copy from “Users” to “Members”

Check if using nameplate layout table to be one “User” column that matches the nameplate style formatting of the user column in the “Users” tab table. with alpha sort

Add confirmation alert for “Remove user from group”

Commentary (optional)

(Optional if easy) Add “Expand/collapse All Groups” + to column header

cannot find easy solution

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit ff66c69
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6532b869f6d2af00075f8abb
😎 Deploy Preview https://deploy-preview-8194--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@keita-determined keita-determined marked this pull request as ready for review October 18, 2023 20:01
@keita-determined keita-determined requested a review from a team as a code owner October 18, 2023 20:01
Copy link
Contributor

@gt2345 gt2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket mentioned about users should be alphabetically sorted, not sure if that's implemented

@keita-determined
Copy link
Contributor Author

The ticket mentioned about users should be alphabetically sorted, not sure if that's implemented

Good catch. I forgot to implement it. Will fix it soon

Copy link
Contributor

@gt2345 gt2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keita-determined keita-determined merged commit 164579f into main Oct 20, 2023
68 of 81 checks passed
@keita-determined keita-determined deleted the feature/update-group-table branch October 20, 2023 17:36
@dannysauer dannysauer added this to the 0.26.3 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants