Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove 'contents' parameter from remove_notes #8209

Merged
merged 1 commit into from
Oct 20, 2023

Commits on Oct 19, 2023

  1. fix: remove 'contents' parameter from remove_notes

    Project notes have name and contents. There is no uniqueness constraint
    on name within a project. This gives an awkward interface for removing a
    note by its name.
    
    Previously, we had logic that optionally took a "contents", so a user
    could narrow down _which_ note to delete when multiple notes had the
    name as the note to be removed. But this interface is complicated, and
    what's the likelihood that a user will event want it. Even more, we
    hadn't implemented all the if/then casing right with "contents", and
    this method had a bug as implemented.
    
    This fixes the bug by removing the feature.
    wes-turner committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    4c2d20a View commit details
    Browse the repository at this point in the history