Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: added cli logging to native. #821

Merged

Conversation

naren-determined
Copy link
Contributor

@naren-determined naren-determined commented Jul 3, 2020

This reverts commit 0c99a0c.

Description

Test Plan

Commentary (optional)

@cla-bot cla-bot bot added the cla-signed label Jul 3, 2020
@naren-determined naren-determined changed the title Revert "feat: added cli logging to native [DET-3316] (#788)" "feat: revert to previous commit" Jul 3, 2020
@naren-determined naren-determined changed the title "feat: revert to previous commit" "fix: revert to previous commit" Jul 3, 2020
@shiyuann shiyuann changed the title "fix: revert to previous commit" revert: added cli logging to native. Jul 3, 2020
@naren-determined naren-determined merged commit afc6e3f into determined-ai:master Jul 3, 2020
hamidzr added a commit to hamidzr/determined that referenced this pull request Jul 7, 2020
Squashed commit of the following:

commit 8f45512
Author: Shiyuan <[email protected]>
Date:   Tue Jul 7 12:31:56 2020 -0700

    test: add nightly test for pytorch flexible primitive example [DET-3534] (determined-ai#827)

    * fix: fix GAN example.

    * test: add nightly test for flexible primitive example

commit e501ea0
Author: Caleb Hoyoul Kang <[email protected]>
Date:   Tue Jul 7 12:07:40 2020 -0600

    feat: experiment list filter [DET-2999, DET-3000] (determined-ai#796)

commit a1b494e
Author: Sidney Wijngaarde <[email protected]>
Date:   Tue Jul 7 12:39:11 2020 -0400

    feat: model versions endpoints [DET-3478] (determined-ai#822)

    Endpoints for managing model versions.

commit 21fb956
Author: Hamid Zare <[email protected]>
Date:   Mon Jul 6 16:36:14 2020 -0700

    fix: fix an issue with cluster resource computation [DET-3509] (determined-ai#832)

    repeat after me: "in JS Array.push does NOT return the resulting array"

commit 1c5d151
Author: naren-determined <[email protected]>
Date:   Mon Jul 6 14:51:21 2020 -0700

    feat: added cli logging to native (determined-ai#833)

    * feat: Native API Logging Improvement [DET-3316]

    * feat: added logging for native

    * feat: added cli logging to native [DET-3316]

    * fix: order of imports for linting

    * fix: migrated logs function from cli to common [DET-3316]

    * fix: trial log path [DET-3316]

    * fix: linting for cli trial.py [DET-3316]

    * buggy test [DET-3316]

    * buggy test part 2 [DET-3316]

    * buggy test number 3 [DET-3316]

    * authentication fix native logging [DET-3316]

    * fix linting native logging [DET-3316]

    * moving authentication_required to common api [DET-3316]

    * fix: added authentication_required to authentication in common [DET-3316]

    * feat: add cli logging to native

commit 6843c8f
Author: katport <[email protected]>
Date:   Mon Jul 6 12:07:21 2020 -0700

    feat: add unets tf.keras example [DET-3397] (determined-ai#825)

commit a9d7007
Author: Yoni Ben-tzur <[email protected]>
Date:   Fri Jul 3 21:52:07 2020 -0700

    feat: clean up swagger spec (determined-ai#823)

commit afc6e3f
Author: naren-determined <[email protected]>
Date:   Thu Jul 2 22:59:49 2020 -0700

    revert: added cli logging to native. (determined-ai#821)

    * Revert "feat: added cli logging to native [DET-3316] (determined-ai#788)"

    This reverts commit 0c99a0c.

    * fix: revert to previous commit

commit 3d42608
Author: Shiyuan <[email protected]>
Date:   Thu Jul 2 20:45:59 2020 -0700

    docs: add example for Pytorch flexible primitives [DET-3202] (determined-ai#778)

commit 0c99a0c
Author: naren-determined <[email protected]>
Date:   Thu Jul 2 19:07:53 2020 -0700

    feat: added cli logging to native [DET-3316] (determined-ai#788)

    * feat: Native API Logging Improvement [DET-3316]

    * feat: added logging for native

    * feat: added cli logging to native [DET-3316]

    * fix: order of imports for linting

    * fix: migrated logs function from cli to common [DET-3316]

    * fix: trial log path [DET-3316]

    * fix: linting for cli trial.py [DET-3316]

    * buggy test [DET-3316]

    * buggy test part 2 [DET-3316]

    * buggy test number 3 [DET-3316]

    * authentication fix native logging [DET-3316]

    * fix linting native logging [DET-3316]

    * moving authentication_required to common api [DET-3316]

    * fix: added authentication_required to authentication in common [DET-3316]
@dannysauer dannysauer added this to the 0.12.11 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants