docs: Apply minor edits #8215
Merged
docs: Apply minor edits #8215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
dzhu
reviewed
Oct 20, 2023
| Currently we support two types of webhooks: ``Slack`` and ``Default``. A payload for a ``Default`` | ||
| webhook will contain information about the event itself, the trigger for the event, and the entity | ||
| that triggered the event. The shape of ``event_data`` is determined by ``event_type``. Below is an | ||
| For webhooks, you have two options: ``Slack`` and ``Default``. A payload for a ``Default`` webhook |
There was a problem hiding this comment.
I don't think I like this better; it seems important to mention "type" as the answer to "options for what?". Perhaps "Determined supports two types of webhooks...".
tara-det-ai
force-pushed
the
docs/Apply-minor-edits
branch
from
9e592d3
to
3056473
Compare
tara-det-ai
force-pushed
the
docs/Apply-minor-edits
branch
from
3056473
to
e08e400
Compare
rb-determined-ai
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typos, apply style guide.