Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(actors): remove actors from resource aggregation [DET-9662] #8265

Merged
merged 1 commit into from
Oct 30, 2023
Merged

chore(actors): remove actors from resource aggregation [DET-9662] #8265

merged 1 commit into from
Oct 30, 2023

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented Oct 27, 2023 •
edited
Loading

Description

Exactly what is says.

Test Plan

No testing required.

Commentary (optional)

Definitely the easiest one.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

DET-9662

@stoksc stoksc requested a review from a team as a code owner October 27, 2023 01:40
@cla-bot cla-bot bot added the cla-signed label Oct 27, 2023
@netlify
Copy link

netlify bot commented Oct 27, 2023 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit dd090a7
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/653b1519ed734d0008626e59

@stoksc stoksc requested review from erikwilson and carolinaecalderon and removed request for amandavialva01 October 27, 2023 01:40
@stoksc stoksc changed the title chore(actors): remove actors from resource aggregation chore(actors): remove actors from resource aggregation [DET-9662] Oct 27, 2023
carolinaecalderon
carolinaecalderon approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoksc stoksc merged commit 0bea20b into main Oct 30, 2023
76 of 86 checks passed
@stoksc stoksc deleted the refactor-allocation-agg branch October 30, 2023 21:03
@dannysauer dannysauer added this to the 0.26.3 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolinaecalderon carolinaecalderon carolinaecalderon approved these changes

@erikwilson erikwilson Awaiting requested review from erikwilson

Assignees

@erikwilson erikwilson

@carolinaecalderon carolinaecalderon

Labels
cla-signed
Projects
None yet
Milestone
0.26.3
Development

Successfully merging this pull request may close these issues.
4 participants
@stoksc @carolinaecalderon @erikwilson @dannysauer