Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use a single root level go mod #8285

Merged
merged 4 commits into from
Nov 3, 2023
Merged

chore: use a single root level go mod #8285

merged 4 commits into from
Nov 3, 2023

Conversation

NicholasBlaskey
Copy link
Contributor

Description

Make Go code use a single go.mod file. This is an alternative to

#8269

Test Plan

CI passes

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@NicholasBlaskey NicholasBlaskey requested a review from a team as a code owner October 31, 2023 16:15
@cla-bot cla-bot bot added the cla-signed label Oct 31, 2023
@netlify Netlify
Copy link

netlify bot commented Oct 31, 2023 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 441e735
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65415b5458ac450008bc42b0

stoksc
stoksc approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@stoksc stoksc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (basically, approach is fine/seems sound to me, if you can get tests passing ship it)

@stoksc
Copy link
Contributor

stoksc commented Oct 31, 2023

i dont love the makefile reaching up into dirs above them, though.

@NicholasBlaskey NicholasBlaskey changed the title chore: use a single root level go mod chore: use a single root level go mod Oct 31, 2023
@NicholasBlaskey NicholasBlaskey mentioned this pull request Oct 31, 2023
Closed
4 tasks
@NicholasBlaskey NicholasBlaskey merged commit 8a1ff58 into main Nov 3, 2023
70 of 82 checks passed
@NicholasBlaskey NicholasBlaskey deleted the single_go_mod branch November 3, 2023 13:36
@dannysauer dannysauer added this to the 0.26.4 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoksc stoksc stoksc approved these changes

Assignees

@stoksc stoksc

Labels
cla-signed
Projects
None yet
Milestone
0.26.4
Development

Successfully merging this pull request may close these issues.
3 participants
@NicholasBlaskey @stoksc @dannysauer