Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undefined handling in CreateGroupModal #8301

Merged
merged 1 commit into from
Nov 1, 2023
Merged

fix: undefined handling in CreateGroupModal #8301

merged 1 commit into from
Nov 1, 2023

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Nov 1, 2023 •
edited by jira bot
Loading

Description

WEB-1789

Test Plan

  • Enable RBAC and go to Group tab in Admin Settings page
  • Check if group without roles should be created without error messsage

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Nov 1, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 1, 2023 •
edited
Loading

✅ Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 8ed7c6f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6542c61068540e0008d52793
😎 Deploy Preview https://deploy-preview-8301--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@keita-determined keita-determined marked this pull request as ready for review November 1, 2023 21:41
@keita-determined keita-determined requested a review from a team as a code owner November 1, 2023 21:41
@keita-determined keita-determined added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Nov 1, 2023
gt2345
gt2345 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@gt2345 gt2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix

@keita-determined keita-determined merged commit 79a324b into main Nov 1, 2023
78 of 88 checks passed
@keita-determined keita-determined deleted the fix/potential-roles-undefiend branch November 1, 2023 21:51
dai-release bot pushed a commit that referenced this pull request Nov 1, 2023
@keita-determined @determined-ci
fix: undefined handling in CreateGroupModal (#8301)
101f279 
(cherry picked from commit 79a324b)
@dannysauer dannysauer added this to the 0.26.4 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gt2345 gt2345 gt2345 approved these changes

@hkang1 hkang1 Awaiting requested review from hkang1 hkang1 is a code owner automatically assigned from determined-ai/web

@julian-determined-ai julian-determined-ai Awaiting requested review from julian-determined-ai

Assignees
No one assigned
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Milestone
0.26.4
Development

Successfully merging this pull request may close these issues.
3 participants
@keita-determined @gt2345 @dannysauer