Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow SAML and OIDC logins to work differently [WEB-1797] #8308

Merged
merged 2 commits into from
Nov 7, 2023
Merged

fix: Allow SAML and OIDC logins to work differently [WEB-1797] #8308

merged 2 commits into from
Nov 7, 2023

Conversation

mapmeld
Copy link
Contributor

@mapmeld mapmeld commented Nov 2, 2023 •
edited
Loading

Description

  • Expects a "type" field for each SSO Provider in the API
  • If we are in OIDC SSO, avoid adding relayState to the URL (it is only used by SAML and is disrupting OIDC)

EE will need to add in this commit ( https://github.com/determined-ai/determined-ee/commit/560f69a7e1cba35e03f241a4cc9ccb73133755f8 ) to include type in its response

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Nov 2, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 2, 2023 •
edited
Loading

✅ Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit c565a2c
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6543eda1d15c3b00082bb283
😎 Deploy Preview https://deploy-preview-8308--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

stoksc
stoksc approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@stoksc stoksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend +1

@stoksc
Copy link
Contributor

stoksc commented Nov 2, 2023

we should figure out the right way to do relay state for oidc sometime

@mapmeld mapmeld marked this pull request as ready for review November 3, 2023 14:40
@mapmeld mapmeld requested review from a team as code owners November 3, 2023 14:40
@mapmeld mapmeld requested review from julian-determined-ai and AmanuelAaron and removed request for AmanuelAaron November 3, 2023 14:40
@mapmeld mapmeld changed the title fix: Allow SAML and OIDC logins to work differently fix: Allow SAML and OIDC logins to work differently [WEB-1797] Nov 3, 2023
@mapmeld mapmeld merged commit 8b6fc68 into main Nov 7, 2023
76 of 86 checks passed
@mapmeld mapmeld deleted the saml_oidc_split branch November 7, 2023 17:10
@dannysauer dannysauer added this to the 0.26.4 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-determined-ai julian-determined-ai julian-determined-ai approved these changes

@stoksc stoksc stoksc approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
0.26.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mapmeld @stoksc @julian-determined-ai @dannysauer