chore: enable more Go linters #8333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
hamidzr
approved these changes
Nov 6, 2023
| @@ -84,79 +84,66 @@ linters-settings: | |||
| linters: | |||
There was a problem hiding this comment.
do you have a resolved list of which ones are effectively moving out of the disabled list through this PR?
There was a problem hiding this comment.
Yep should be
bidichk
containedctx
decorder
durationcheck
errname
exhaustruct
gofumpt
gosimple
grouper
importas
makezero
nilerr
noctx
tenv
tparallel
usestdlibvars
NicholasBlaskey
force-pushed
the
enable_more_linters
branch
from
6a0c73f
to
04f5dc4
Compare
|
Admin merging over failing test_launch_layer_mnist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables and sorts remaining linters left to be enabled.
Please review the EE changes commit here https://github.com/determined-ai/determined-ee/pull/1118
Test Plan
CI passes
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket