chore: Remove DesignKit since it's now maintained in Hew [WEB-1790] #8338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
you should be able to remove |
|
also, |
|
since @keita-determined identified #6707, I took a look, and I think there's more that could be removed from |
|
@johnkim-det we did some research late yesterday
|
ashtonG
reviewed
Nov 7, 2023
| @@ -141,9 +140,6 @@ export default defineConfig(({ mode }) => ({ | |||
| checker({ | |||
| typescript: true, | |||
| }), | |||
| devServerRedirects({ | |||
There was a problem hiding this comment.
should be able to remove the devServerRedirects plugin here
johnkim-det
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The DesignKit and visual diffs are now in Hew
For example in this PR determined-ai/hew#27 it got an automated UI kit diff
Test Plan
Any removed tests are running in Hew
Existing site builds, tests pass
Checklist
docs/release-notes/.See Release Note for details.