Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hide column header menu item to explist #8342

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

ashtonG
Copy link
Contributor

@ashtonG ashtonG commented Nov 6, 2023

Description

This adds a header menu item to the experiment list table that hides the column from view. If the column is pinned, the column is unpinned when hidden.

Test Plan

  • when visiting the experiment list table, click on a column header. The "hide column" menu item should appear in the header menu.
  • after clicking on the "hide column" menu item, the column should not show up in the table
  • after clicking on the "hide column" menu item when the column is pinned, the column should not show up in the table, and the number of pinned columns should decrease

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

WEB-1781

@ashtonG ashtonG requested a review from a team as a code owner November 6, 2023 19:55
@cla-bot cla-bot bot added the cla-signed label Nov 6, 2023
Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 5aea523
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65494508a3f65b0008cb9402
😎 Deploy Preview https://deploy-preview-8342--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashtonG ashtonG force-pushed the feat/WEB-1781/experiments-hide-column branch from 88fdd7d to 5aea523 Compare November 6, 2023 19:56
Copy link
Contributor

@EmilyBonar EmilyBonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashtonG ashtonG merged commit b428d5e into main Nov 9, 2023
71 of 81 checks passed
@ashtonG ashtonG deleted the feat/WEB-1781/experiments-hide-column branch November 9, 2023 20:33
@dannysauer dannysauer added this to the 0.26.4 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants