ci: update webui e2e tests to kill experiment instead of cancel [DET-3543] #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkang1
changed the title
dzhu
approved these changes
Jul 7, 2020
👍 Can't hurt to rerun it a few times before merging. |
eecsliu
pushed a commit
to eecsliu/determined
that referenced
this pull request
Jun 23, 2023
stoksc
added a commit
that referenced
this pull request
Jun 26, 2023
eecsliu
pushed a commit
that referenced
this pull request
Jun 28, 2023
eecsliu
pushed a commit
that referenced
this pull request
Jun 28, 2023
stoksc
added a commit
that referenced
this pull request
Jul 20, 2023
eecsliu
pushed a commit
that referenced
this pull request
Jul 24, 2023
stoksc
added a commit
that referenced
this pull request
Oct 17, 2023
azhou-determined
pushed a commit
that referenced
this pull request
Dec 7, 2023
wes-turner
pushed a commit
that referenced
this pull request
Feb 2, 2024
rb-determined-ai
pushed a commit
that referenced
this pull request
Feb 29, 2024
amandavialva01
pushed a commit
that referenced
this pull request
Mar 18, 2024
eecsliu
pushed a commit
that referenced
this pull request
Apr 18, 2024
eecsliu
pushed a commit
to determined-ai/determined-release-testing
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
webui e2e-tests are getting blocked on the experiment cancelation step due to the experiment taking a while to pull a docker image. The pulling is taking longer than the 30 second cypress time limit on the response. The solution is to use the kill step instead.
Test Plan
Check for CI stability around webui e2e-tests. Specifically a reduction in test flakes for experiment cancelation, starting in
01-setuptest suite.Commentary (optional)