Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set group name and number columns to handle Safari [DET-9948] [DET-9949] #8355

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

mapmeld
Copy link
Contributor

@mapmeld mapmeld commented Nov 7, 2023

Description

On Safari, the group admin page wasn't showing group names
We researched and found Safari/WebKit uses width: intrinsic instead of fit-content

After discussion on Slack about this ticket and #8309 , best option is 100% width

We also added parentheses around the number of groups or users

Test Plan

On /det/admin/user-management,

With EE backend, group name column appears on Safari without issues

Users and Groups tabs appear with a number in parentheses. (If groups is undefined, the Group parentheses and number do not appear)

Screen Shot 2023-11-07 at 1 03 02 PM

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit b751632
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/654a8a7228997000070a4a9b
😎 Deploy Preview https://deploy-preview-8355--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mapmeld mapmeld changed the title fix: Set group name and number columns to handle Safari [DET-9948] fix: Set group name and number columns to handle Safari [DET-9948] [DET-9949] Nov 7, 2023
@mapmeld
Copy link
Contributor Author

mapmeld commented Nov 7, 2023

Updated test plan; thanks for the suggested change

@mapmeld mapmeld enabled auto-merge (squash) November 7, 2023 19:10
@mapmeld mapmeld merged commit 5ee87ec into main Nov 7, 2023
71 of 82 checks passed
@mapmeld mapmeld deleted the group_table branch November 7, 2023 19:12
@dannysauer dannysauer added this to the 0.26.4 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants