Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: up parallelism for slowest test_e2e premerge tests #8374

Merged
merged 18 commits into from
Nov 13, 2023
Merged

ci: up parallelism for slowest test_e2e premerge tests #8374

merged 18 commits into from
Nov 13, 2023

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented Nov 8, 2023 •
edited
Loading

Description

Improve speed of e2e tests by upping parallelism

removing some redundant tests parameters

and rearranged test_custom_searcher into a test_custom_searcher_asha.py file.

Test Plan

CI passes, see a good run here https://app.circleci.com/pipelines/github/determined-ai/determined/47862/workflows/60f32508-ce22-4b87-9151-643ce5d8bd14

Commentary (optional)

delete_checkpoint is going to take 20 minutes while we wait for this to land #8377

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Nov 8, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 8, 2023 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit b95d9d5
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/655235e2c9d48e0008a6672b

@NicholasBlaskey NicholasBlaskey changed the title ci: up parallelism for e2e_cpu and managed_devcluster ci: up parallelism for slowest test_e2e premerge tests Nov 9, 2023
@NicholasBlaskey NicholasBlaskey marked this pull request as ready for review November 9, 2023 17:50
@NicholasBlaskey NicholasBlaskey requested review from a team as code owners November 9, 2023 17:50
@NicholasBlaskey NicholasBlaskey merged commit ba49dbd into main Nov 13, 2023
70 of 80 checks passed
@NicholasBlaskey NicholasBlaskey deleted the up_parallelism branch November 13, 2023 18:30
@dannysauer dannysauer added this to the 0.26.4 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rb-determined-ai rb-determined-ai rb-determined-ai approved these changes

@stoksc stoksc stoksc approved these changes

@dannysauer dannysauer Awaiting requested review from dannysauer

Assignees

@dannysauer dannysauer

@stoksc stoksc

@rb-determined-ai rb-determined-ai

Labels
cla-signed
Projects
None yet
Milestone
0.26.4
Development

Successfully merging this pull request may close these issues.
4 participants
@NicholasBlaskey @stoksc @rb-determined-ai @dannysauer