Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cache go modules deps and build cache #8383

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented Nov 9, 2023

Description

Our Go cache was suboptimal not saving build deps or even master go modules.

Test Plan

CI passes and second run build-go speed increases.

Looks like cache hit went from 4 minute go build to 2 minute go build

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Nov 9, 2023
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit bc0d91f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/654d3f5234f175000801e0c2
😎 Deploy Preview https://deploy-preview-8383--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NicholasBlaskey NicholasBlaskey marked this pull request as ready for review November 9, 2023 20:29
@NicholasBlaskey NicholasBlaskey merged commit d3c208a into main Nov 13, 2023
68 of 80 checks passed
@NicholasBlaskey NicholasBlaskey deleted the build_cache_golang branch November 13, 2023 20:59
@dannysauer dannysauer added this to the 0.26.4 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants