Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(actors): remove pkg/actor usage from agentrm #8395

Merged
merged 11 commits into from
Nov 18, 2023

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented Nov 11, 2023

Description

This is the product of 3 stacked PRs.

The first rewrote the agents and agent actors as non-actors. I started by refactoring the interactions
between resource managers, resource pools and agents; the agent management subsystem can
be instantiated without a dependency on resource pools, it has a clear API for external consumers
and the resource manager and pools are wired up to use this API.

The second and third wrote the resource pool and manager, respectively, without pkg/actor. Once
the interactions between agents and these were fixed by the first, they mostly just fell into place;
for each message that the actor used to handle, it got a public method for callers instead.

This is the last major change required to remove pkg/actor.

Test Plan

Covered by automated tests and "make sure agentrm works well".

Commentary (optional)

Woohoo.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

DET-9656

@cla-bot cla-bot bot added the cla-signed label Nov 11, 2023
@stoksc stoksc marked this pull request as ready for review November 17, 2023 17:07
@stoksc stoksc requested a review from a team as a code owner November 17, 2023 17:07
@stoksc stoksc requested review from erikwilson and removed request for a team November 17, 2023 17:07
@stoksc stoksc force-pushed the stoksc/chore/refactor-agentrm-rm branch from a874c2f to 1734584 Compare November 18, 2023 02:56
@stoksc stoksc requested review from a team as code owners November 18, 2023 02:56
@stoksc stoksc requested review from mapmeld and tayritenour and removed request for a team November 18, 2023 02:56
Copy link

cla-bot bot commented Nov 18, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @determined-ci on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla.

After we approve your CLA, we will update the contributors list (private) and comment @cla-bot[bot] check to rerun the check.

@cla-bot cla-bot bot removed the cla-signed label Nov 18, 2023
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci determined-ci requested a review from a team November 18, 2023 02:56
@stoksc stoksc changed the base branch from stoksc/chore/refactor-agentrm-rp to main November 18, 2023 02:56
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Nov 18, 2023
@stoksc stoksc removed request for a team, mapmeld and tayritenour November 18, 2023 02:56
@cla-bot cla-bot bot added the cla-signed label Nov 18, 2023
Copy link

cla-bot bot commented Nov 18, 2023

The cla-bot has been summoned, and re-checked this pull request!

@stoksc stoksc merged commit 192a2b3 into main Nov 18, 2023
80 of 88 checks passed
@stoksc stoksc deleted the stoksc/chore/refactor-agentrm-rm branch November 18, 2023 04:37
@dannysauer dannysauer added this to the 0.26.5 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants