-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(actors): remove pkg/actor usage from agentrm #8395
Conversation
a874c2f
to
1734584
Compare
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @determined-ci on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla. After we approve your CLA, we will update the contributors list (private) and comment |
Docsite preview being generated for this PR. |
The cla-bot has been summoned, and re-checked this pull request! |
Description
This is the product of 3 stacked PRs.
The first rewrote the agents and agent actors as non-actors. I started by refactoring the interactions
between resource managers, resource pools and agents; the agent management subsystem can
be instantiated without a dependency on resource pools, it has a clear API for external consumers
and the resource manager and pools are wired up to use this API.
The second and third wrote the resource pool and manager, respectively, without pkg/actor. Once
the interactions between agents and these were fixed by the first, they mostly just fell into place;
for each message that the actor used to handle, it got a public method for callers instead.
This is the last major change required to remove pkg/actor.
Test Plan
Covered by automated tests and "make sure agentrm works well".
Commentary (optional)
Woohoo.
Checklist
docs/release-notes/
.See Release Note for details.
Ticket
DET-9656