-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add remote user settings to Users table [WEB-1798] #8397
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backend +1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall works as expected!
Could you please look into why the order in the table is different from the order from the API response? Note that user remote1
should be the first but instead it's last.
Should we change the success message when creating a remote user?
At the group tab, should we somehow denote an user is remote or not?
I don't have a personal preference, but the ticket mentioned a checkbox for selecting remote in the modal?
b1d0ecd
to
9c60de1
Compare
OK I made 2 fixes: reversed local sort order, and updated the toast message for remote users. |
9c60de1
to
d2f77d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
In an EE/RBAC environment,
Test Plan
In an EE/RBAC environment,
As an admin, visit
/det/admin/user-management
and see the Remote column (most rows say Local)Create a new user. Set the "Remote" toggle on. Create another user with the "Remote" toggle off.
Check that both users appear in the users table with correct Local/Remote values
Change Remote status on a user
Test sort on the Remote column
Checklist
docs/release-notes/
.See Release Note for details.