Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add remote user settings to Users table [WEB-1798] #8397

Merged
merged 9 commits into from
Nov 16, 2023
Merged

Conversation

mapmeld
Copy link
Contributor

@mapmeld mapmeld commented Nov 13, 2023

Description

In an EE/RBAC environment,

  • Adds a sortable "Remote" column to Users table
  • Create/edit user modal has a Remote toggle
  • Remote users do not have option to change their password in WebUI (message is: "Remote user cannot change password from WebUI")

Test Plan

In an EE/RBAC environment,

As an admin, visit /det/admin/user-management and see the Remote column (most rows say Local)
Create a new user. Set the "Remote" toggle on. Create another user with the "Remote" toggle off.
Check that both users appear in the users table with correct Local/Remote values
Change Remote status on a user
Test sort on the Remote column

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit d2f77d7
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6553e7eb791fed0008dc7d93
😎 Deploy Preview https://deploy-preview-8397--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mapmeld mapmeld changed the title Add remote user settings to Users table [WEB-1798] feat: Add remote user settings to Users table [WEB-1798] Nov 13, 2023
Copy link
Contributor

@stoksc stoksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend +1

Copy link
Contributor

@gt2345 gt2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall works as expected!

Could you please look into why the order in the table is different from the order from the API response? Note that user remote1 should be the first but instead it's last.
Screenshot 2023-11-13 at 12 18 47 PM

Should we change the success message when creating a remote user?
Screenshot 2023-11-13 at 12 23 26 PM

At the group tab, should we somehow denote an user is remote or not?

I don't have a personal preference, but the ticket mentioned a checkbox for selecting remote in the modal?

@mapmeld
Copy link
Contributor Author

mapmeld commented Nov 13, 2023

OK I made 2 fixes: reversed local sort order, and updated the toast message for remote users.
I think the toggle is the right way for remote users instead of checkbox. The same modal has an Admin on/off toggle on OSS

Copy link
Contributor

@gt2345 gt2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mapmeld mapmeld merged commit 7b7d1eb into main Nov 16, 2023
69 of 80 checks passed
@mapmeld mapmeld deleted the remote_users branch November 16, 2023 19:37
@dannysauer dannysauer added this to the 0.26.5 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants