Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: set up ownership for .circleci directory [skip ci] #8402

Merged
merged 1 commit into from
Nov 21, 2023
Merged

chore: set up ownership for .circleci directory [skip ci] #8402

merged 1 commit into from
Nov 21, 2023

Conversation

dannysauer
Copy link
Member

Description

set up ownership for .circleci directory

Test Plan

See if anyone complains about the file contents

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@dannysauer dannysauer requested a review from a team as a code owner November 13, 2023 21:15
@cla-bot cla-bot bot added the cla-signed label Nov 13, 2023
@dannysauer
Copy link
Member Author

I need some input on the devcluster and packaging directories. Who wants to own those?

@dannysauer dannysauer force-pushed the chore/dannys/infra-circleci-ownership branch from 4cd4e93 to ed0249e Compare November 13, 2023 21:20
@erikwilson
Copy link
Contributor

I need some input on the devcluster and packaging directories. Who wants to own those?

Seems like infra should be the codeowner for all of .circleci

erikwilson
erikwilson approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@erikwilson erikwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, backend owning those directories makes sense :)

@dannysauer
Copy link
Member Author

I'm sold. Let's see how much extra work this creates. 😂

@dannysauer dannysauer merged commit 5805df2 into main Nov 21, 2023
6 checks passed
@dannysauer dannysauer deleted the chore/dannys/infra-circleci-ownership branch November 21, 2023 20:11
@dannysauer dannysauer added this to the 0.26.5 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loksonarius loksonarius loksonarius approved these changes

@erikwilson erikwilson erikwilson approved these changes

@ioga ioga Awaiting requested review from ioga

@NicholasBlaskey NicholasBlaskey Awaiting requested review from NicholasBlaskey

@rb-determined-ai rb-determined-ai Awaiting requested review from rb-determined-ai

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
0.26.5
Development

Successfully merging this pull request may close these issues.
3 participants
@dannysauer @erikwilson @loksonarius