Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: export AddUserTx #8403

Merged
merged 1 commit into from
Nov 14, 2023
Merged

chore: export AddUserTx #8403

merged 1 commit into from
Nov 14, 2023

Conversation

carolinaecalderon
Copy link
Contributor

Description

Create a public AddUser transaction for use in other areas of the code where we want to run multiple Bun queries in a transaction.

Test Plan

Pass CircleCI Tests.

Commentary (optional)

Used here: https://github.com/determined-ai/determined-ee/pull/1121.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Nov 13, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 13, 2023 •
edited
Loading

✅ Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 4fc8d45
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/655297964c3ade00081da5ed
😎 Deploy Preview https://deploy-preview-8403--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@carolinaecalderon carolinaecalderon marked this pull request as ready for review November 13, 2023 21:41
@carolinaecalderon carolinaecalderon requested a review from a team as a code owner November 13, 2023 21:41
NicholasBlaskey
NicholasBlaskey approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making this change

I know the ee split makes stuff like this especially difficult

@carolinaecalderon carolinaecalderon merged commit 2497d84 into main Nov 14, 2023
74 of 84 checks passed
@carolinaecalderon carolinaecalderon deleted the carolinac/chore-add-user-tx branch November 14, 2023 16:05
@dannysauer dannysauer added this to the 0.26.4 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasBlaskey NicholasBlaskey NicholasBlaskey approved these changes

@corban-beaird corban-beaird Awaiting requested review from corban-beaird corban-beaird is a code owner automatically assigned from determined-ai/backend

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
0.26.4
Development

Successfully merging this pull request may close these issues.
3 participants
@carolinaecalderon @NicholasBlaskey @dannysauer