Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revert task obfuscation lint failures #8406

Merged
merged 2 commits into from
Nov 13, 2023
Merged

chore: revert task obfuscation lint failures #8406

merged 2 commits into from
Nov 13, 2023

Conversation

amandavialva01
Copy link
Contributor

Reverts #8311

@amandavialva01 amandavialva01 requested review from a team as code owners November 13, 2023 22:28
@cla-bot cla-bot
Copy link

cla-bot bot commented Nov 13, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @amandavialva01 on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla.

After we approve your CLA, we will update the contributors list (private) and comment @cla-bot[bot] check to rerun the check.

@netlify Netlify
Copy link

netlify bot commented Nov 13, 2023 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit e6bdf74
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6552a7da448aa9000810127c

@amandavialva01 amandavialva01 changed the title Revert "fix: NTSC task and slot viewing obscured for RBAC users with no Viewer Permissions" Revert "fix: NTSC task and slot viewing for RBAC users with no permissions" Nov 13, 2023
@amandavialva01 amandavialva01 force-pushed the revert-8311-amanda/rbacTaskPermissionClassification branch from b2cd8cb to 17886bc Compare November 13, 2023 22:42
@cla-bot cla-bot bot added the cla-signed label Nov 13, 2023
@amandavialva01 amandavialva01 changed the title Revert "fix: NTSC task and slot viewing for RBAC users with no permissions" "revert: fix NTSC task and slot viewing for RBAC users with no permissions" Nov 13, 2023
@cla-bot cla-bot
Copy link

cla-bot bot commented Nov 13, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @amandavialva01 on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla.

After we approve your CLA, we will update the contributors list (private) and comment @cla-bot[bot] check to rerun the check.

@cla-bot cla-bot bot removed the cla-signed label Nov 13, 2023
@NicholasBlaskey NicholasBlaskey changed the title "revert: fix NTSC task and slot viewing for RBAC users with no permissions" chore: revert task obfuscation lint failures Nov 13, 2023
@amandavialva01 amandavialva01 enabled auto-merge (squash) November 13, 2023 22:53
@amandavialva01 amandavialva01 merged commit 16f18cc into main Nov 13, 2023
67 of 83 checks passed
@amandavialva01 amandavialva01 deleted the revert-8311-amanda/rbacTaskPermissionClassification branch November 13, 2023 23:04
@dannysauer dannysauer added this to the 0.26.4 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azhou-determined azhou-determined azhou-determined approved these changes

@NicholasBlaskey NicholasBlaskey NicholasBlaskey approved these changes

@tayritenour tayritenour Awaiting requested review from tayritenour tayritenour was automatically assigned from determined-ai/ml-sys

@salonig23 salonig23 Awaiting requested review from salonig23 salonig23 is a code owner automatically assigned from determined-ai/backend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.26.4
Development

Successfully merging this pull request may close these issues.
4 participants
@amandavialva01 @NicholasBlaskey @azhou-determined @dannysauer