Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix model registry rbac wrong user regression #8420

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented Nov 15, 2023

Description

Fixes regression in a test here https://github.com/determined-ai/determined-ee/commit/af995bac832416b051807eace4bff36470d6eaf8#diff-a9b7f55f9139ab19c01a[…]72aba40dbbe7ffe21002fR354

Test Plan

EE passes here https://app.circleci.com/pipelines/github/determined-ai/determined-ee/10129/workflows/e317463f-c75d-4d6b-93d3-e4ce85edc1d6/jobs/486806

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit b1c2ca3
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6554fdce8c138100082c089c

@NicholasBlaskey NicholasBlaskey added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Nov 15, 2023
@NicholasBlaskey
Copy link
Contributor Author

admin merging over master intg flake

@NicholasBlaskey NicholasBlaskey merged commit 8e9c505 into main Nov 16, 2023
72 of 85 checks passed
@NicholasBlaskey NicholasBlaskey deleted the fix_model_reg_rbac branch November 16, 2023 17:36
dai-release bot pushed a commit that referenced this pull request Nov 16, 2023
@dannysauer dannysauer added this to the 0.26.5 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants