fix: Wrap older modals in theme class [WEB-1824]

[mapmeld]

Description

Applies system/light/dark theme to hyperparameter, notebook, or any old-style modal still inside src/hooks/useModal

Test Plan

Switch to dark mode.
In a single-trial experiment, open the Hyperparameter tab, then click the Hyperparameter Search button
The background should be solid, and the title font-family should come from a CSS variable

Checklist

• Changes have been manually QA'd
• User-facing API changes need the "User-facing API Change" label.
• Release notes should be added as a separate file under docs/release-notes/.
  See Release Note for details.
• Licenses should be included for new code which was copied and/or modified from any external code.

[netlify]

✅ Deploy Preview for determined-ui ready!

Name	Link
🔨 Latest commit	8d95aeb
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/655641c37ea7f700081b5fcb
😎 Deploy Preview	https://deploy-preview-8432--determined-ui.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[julian-determined-ai]

Could you also update the GalleryModal?

[johnkim-det]

This fixes the Hyperparameter Search modal, but it actually looks like the "Use in Notebook" modal doesn't use the determined useModal hook, it just imports and uses the antd Modal directly. And there may be several modals where we do this.

So I think we need to apply the theme class to any direct imports of antd Modals, or use the useModal hook in those places, or replace them with hew Modals.

[johnkim-det]

I think we want to think about the long-term solution, but probably the simplest fix for release is to just import useTheme and apply themeClass to all of these:

[mapmeld]

@johnkim-det I think we had the same idea to search - the latest commit extends this to other uses of Antd Modal except for the Omnibar help (because it's not a function component and can't call useTheme...)

[johnkim-det]

LGTM

[ClaireNeveu]

@mapmeld Can you make a ticket to migrate these?

[mapmeld]

@ClaireNeveu ok I made 3 tickets, because some are more complex than others