Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Experiment List Tooltip is Transparent [WEB-1827] #8433

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

julian-determined-ai
Copy link
Contributor

Description

The Tooltip used in our useTableTooltip method is currently imported from Antd and not Hew. This update implements the Hew tooltip.

Test Plan

  1. Navigate to the experiment comparison table on the uncategorized page or any workspace project.
  2. Ensure the State and User columns are enabled. You can enable them by clicking the "Columns" button on top of the table.
  3. With the theme in light mode, hover over the user icon and then the state icon, ensure that both tooltips that show have a solid background.
  4. With the theme in dark mode, hover over the user icon and then the state icon, ensure that both tooltips that show have a solid background.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

WEB-1827

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 3d7458f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65564273b8ffc100084203d5
😎 Deploy Preview https://deploy-preview-8433--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@mapmeld mapmeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ fixes the issue, LGTM

@julian-determined-ai julian-determined-ai merged commit 292c75d into main Nov 16, 2023
72 of 83 checks passed
@julian-determined-ai julian-determined-ai deleted the fix-web-1827 branch November 16, 2023 16:33
@NicholasBlaskey NicholasBlaskey added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Nov 16, 2023
dai-release bot pushed a commit that referenced this pull request Nov 16, 2023
@dannysauer dannysauer added this to the 0.26.5 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants