chore: run migration moving trials to view and rename [DET-9989] #8440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
NicholasBlaskey
force-pushed
the
first_run_migration
branch
from
373076d
to
3f9c384
Compare
NicholasBlaskey
force-pushed
the
first_run_migration
branch
from
1e3d8f6
to
2b76370
Compare
NicholasBlaskey
commented
Nov 27, 2023
master/static/migrations/20231127110554_trial-to-run-view.tx.up.sql
Outdated
Show resolved
Hide resolved
NicholasBlaskey
changed the title
NicholasBlaskey
force-pushed
the
first_run_migration
branch
from
934c33a
to
be4bfb9
Compare
stoksc
approved these changes
Nov 29, 2023
master/static/migrations/20231127110554_trial-to-run-view.tx.up.sql
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| // ToRun converts a trial to a run. | ||
| func (t *Trial) ToRun() *Run { |
There was a problem hiding this comment.
write a test to make sure this is exhaustive? or turn the linter on for this struct?
There was a problem hiding this comment.
added a test
| @@ -168,7 +172,7 @@ func (db *PgDB) UpdateTrialRunnerState(id int, state string) error { | |||
| // UpdateTrialRunnerMetadata updates a trial's metadata about its runner. | |||
| func (db *PgDB) UpdateTrialRunnerMetadata(id int, md *trialv1.TrialRunnerMetadata) error { | |||
| if _, err := db.sql.Exec(` | |||
| UPDATE trials | |||
| UPDATE runs | |||
There was a problem hiding this comment.
we could use a better strategy for updates than this, lol (500 different functions for each field).
There was a problem hiding this comment.
// UpdateTrial updates an existing trial. Fields that are nil or zero are not
// updated. end_time is set if the trial moves to a terminal state.
func (db *PgDB) UpdateTrial(id int, newState model.State) error {
I agree, created https://hpe-aiatscale.atlassian.net/browse/DET-9993
update trial comment makes me think that it used to take multiple fields
| _, err := tx.NewUpdate().Model(&obj).WherePK(). | ||
| Set("run_id = run_id + 1"). | ||
| run := model.Run{ID: trialID} | ||
| _, err := tx.NewUpdate().Model(&run).WherePK(). |
There was a problem hiding this comment.
it'd be nice to put all these calls into a "runs" package eventually, instead of scattered over the entire codebase. can we start TODO'ing it if you agree?
There was a problem hiding this comment.
Added some TODOs
NicholasBlaskey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First step of migration towards runs.
Only changes are
trialstable renamed toruns,run_idtorestart_id,external_trial_idtoexternal_run_id, and a view.Test Plan
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket