chore: add error check to KillNTSC #8441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
stoksc
reviewed
Nov 17, 2023
carolinaecalderon
force-pushed
the
command-onexit-check-error
branch
from
b5be739
to
0b14e65
Compare
stoksc
approved these changes
Nov 18, 2023
|
oh wait, wasn't the err check on the allocation service call? it's on db now. |
stoksc
requested changes
Nov 18, 2023
carolinaecalderon
changed the title
stoksc
approved these changes
Nov 20, 2023
|
nit, commit comment (pr desc) doesn't match behavior anymore. |
stoksc
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In KillNTSC, if
Signalreturns a not found error, continue & don't return an error. This fixes a potential race condition where the db says a command isn't completed yet the allocation has already exited. This also addresses the case where if a user asks to kill a successfully exited NTSCs, it won't attempt toSignal& kill its allocation a second time.Test Plan
Pass CircleCI
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket