Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SDK list_checkpoints not defaulting to searcher metric sort #8448

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

azhou-determined
Copy link
Contributor

Description

calling list_checkpoints without sort and order parameters is supposed to default to the experiment's searcher config, but instead falls through to sorting by ID on the backend.

Test Plan

Ensure that calling list_checkpoints without any arguments returns a list of checkpoints sorted by the experiment's searcher metric and smaller_is_better

client = experimental.Determined(master=DET_MASTER, user="determined", password="")
    ckpts = client.get_experiment(1).list_checkpoints()
    print(ckpts)

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 3eb8a87
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6557bcfc32e0590008ee9e2b
😎 Deploy Preview https://deploy-preview-8448--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@wes-turner wes-turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh. Probably was safer to do it this way in the first place. I'm often finding myself curious about the defaults the backend uses.

LGTM

I don't think this needs a regression test, but mentioning it here in case you think different and hadn't considered it.

@azhou-determined azhou-determined merged commit 695a648 into main Nov 17, 2023
70 of 83 checks passed
@azhou-determined azhou-determined deleted the sdk-list-checkpoints branch November 17, 2023 20:37
@dannysauer dannysauer added this to the 0.26.5 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants