Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(actors): remove pkg/actor #8452

Merged
merged 1 commit into from
Nov 21, 2023
Merged

chore(actors): remove pkg/actor #8452

merged 1 commit into from
Nov 21, 2023

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented Nov 18, 2023 •
edited
Loading

Description

Remove pkg/actor, fix all tests broken by this removal, and a few non-test files that imported it and didn't use it.

Test Plan

Covered by automated testing.

Commentary (optional)

💯

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

DET-9979

@cla-bot cla-bot bot added the cla-signed label Nov 18, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 18, 2023 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit c5a7437
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/655c189a6a57440008cda92a

@stoksc stoksc marked this pull request as ready for review November 19, 2023 16:49
@stoksc stoksc requested a review from a team as a code owner November 19, 2023 16:49
erikwilson
erikwilson approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@erikwilson erikwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@stoksc stoksc merged commit dfb4dc5 into main Nov 21, 2023
70 of 81 checks passed
@stoksc stoksc deleted the stoksc/chore/rm-pkg-actor branch November 21, 2023 03:28
@dannysauer dannysauer added this to the 0.26.5 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikwilson erikwilson erikwilson approved these changes

Assignees

@erikwilson erikwilson

Labels
cla-signed
Projects
None yet
Milestone
0.26.5
Development

Successfully merging this pull request may close these issues.
3 participants
@stoksc @erikwilson @dannysauer