fix(api): handle delete experiment failures correctly #8459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
jgongd
reviewed
Nov 21, 2023
jgongd
reviewed
Nov 21, 2023
| @@ -48,7 +48,9 @@ var ( | |||
| // called twice for the same resource, etc). | |||
| func MockRM() *mocks.ResourceManager { | |||
| var mockRM mocks.ResourceManager | |||
| mockRM.On("DeleteJob", mock.Anything).Return(sproto.EmptyDeleteJobResponse(), nil) | |||
| mockRM.On("DeleteJob", mock.Anything).Return(func(sproto.DeleteJob) sproto.DeleteJobResponse { | |||
There was a problem hiding this comment.
question: why need a function func(sproto.DeleteJob) instead of returning sproto.EmptyDeleteJobResponse() directly?
There was a problem hiding this comment.
because the response gets reused for everything that calls it, and so we don't get a new channel and 2/3 of the jobs block indefinitely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DeleteExperiments was misinterpreting the response from a function it called, resulting in non-sense behavior. I improved the API of the function and fixed the calling code. I also fixed some cases where we were erroneously logging errors on success cases.
Test Plan
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket
DET-9978