chore: preserve CI logs when bringing an AWS cluster down #8461

erikwilson · 2023-11-21T18:28:14Z

Description

Cloudformation logs are removed when we bring CI clusters down, this option will retain them so logs can be examined when tests fail.

Changes have been manually QA'd
User-facing API changes need the "User-facing API Change" label.
Release notes should be added as a separate file under docs/release-notes/.
See Release Note for details.
Licenses should be included for new code which was copied and/or modified from any external code.

netlify · 2023-11-21T18:28:21Z

Name	Link
🔨 Latest commit	`63c8ae3`
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/655d41fec009fa0008291708
😎 Deploy Preview	https://deploy-preview-8461--determined-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

harness/determined/deploy/aws/deployment_types/base.py

chore: preserve CI logs when bringing an AWS cluster down

3d2a6ca

cla-bot bot added the cla-signed label Nov 21, 2023

erikwilson requested a review from dannysauer November 21, 2023 18:28

include missing RetainLogGroup cloudformation parameter

bb815cc

erikwilson requested review from a team as code owners November 21, 2023 20:58

erikwilson requested a review from rb-determined-ai November 21, 2023 20:58

ioga reviewed Nov 21, 2023

View reviewed changes

harness/determined/deploy/aws/deployment_types/base.py Outdated Show resolved Hide resolved

update from comment

63c8ae3

ioga approved these changes Nov 22, 2023

View reviewed changes

erikwilson merged commit e67807d into main Nov 22, 2023
69 of 82 checks passed

erikwilson deleted the erikw/aws-down-preserve-logs branch November 22, 2023 14:27

dannysauer added this to the 0.26.5 milestone Feb 6, 2024