Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update libraries #8463

Merged
merged 13 commits into from
Nov 28, 2023
Merged

chore: update libraries #8463

merged 13 commits into from
Nov 28, 2023

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Nov 21, 2023

Description

WEB-1802

Test Plan

  • npm build/test/lint should work
  • Check if there's no regression in web pages.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Nov 21, 2023
Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit d775eb3
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65653c5123ee880008e461b1
😎 Deploy Preview https://deploy-preview-8463--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@keita-determined keita-determined marked this pull request as ready for review November 21, 2023 21:36
@keita-determined keita-determined requested a review from a team as a code owner November 21, 2023 21:36
@keita-determined keita-determined force-pushed the chore/update-libraries branch 3 times, most recently from 5cb4827 to 1685b22 Compare November 21, 2023 22:48
@keita-determined keita-determined requested a review from a team as a code owner November 21, 2023 22:48
@keita-determined keita-determined force-pushed the chore/update-libraries branch 2 times, most recently from 67a4279 to 7a84045 Compare November 21, 2023 22:55
@keita-determined
Copy link
Contributor Author

keita-determined commented Nov 21, 2023

not sure why e2e keep failing only on webkit. Looks like playwright version doesnt matter and e2e works fine on local.
@mapmeld do you have any idea why its failing?

probably this in the error?

libsoup3 symbols detected. Using libsoup2 and libsoup3 in the same process is not supported.

maybe switch back to the playwright docker image might resolve the issue but not sure why it is changed to this

- image: cimg/node:20.9.0

@keita-determined keita-determined force-pushed the chore/update-libraries branch 3 times, most recently from 24017be to 16d2ae4 Compare November 21, 2023 23:28
@keita-determined keita-determined force-pushed the chore/update-libraries branch 2 times, most recently from 753d65e to 2076fa0 Compare November 27, 2023 23:16
Copy link
Contributor

@mapmeld mapmeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ thanks for working through the build issues

Copy link
Member

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions from me, but not blockers. Approving the config change under the assumption that they weren't mistakes. :)

@@ -1513,14 +1513,15 @@ jobs:

test-e2e-react:
docker:
- image: cimg/node:20.9.0
- image: mcr.microsoft.com/playwright:v1.40.0-focal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably quicker to run with the Circle convenience images. Does the Microsoft-hosted image have an advantage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for the playwright, cimg/node:20.9.0 is not straightforward to setup. We used to MS image, but at some point, it was replaced with cimg/node:20.9.0 with Playwright version downgrade. That's not what we want because that prevents us to use the latest playwright version.

- react-get-deps
- run: npx playwright install --with-deps chrome firefox webkit
- run: npx playwright install --with-deps && npx playwright install chrome
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to install Firefox and webkit in the first install command? Is that installing nothing, or is there a default file with stuff to install somewhere?

Copy link
Contributor Author

@keita-determined keita-determined Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc and this doc might be helpful.
We list browsers here

projects: [
{
name: 'chromium',
use: { ...devices['Desktop Chrome'], channel: 'chrome' },
},
{
name: 'firefox',
use: { ...devices['Desktop Firefox'] },
},
{
name: 'webkit',
use: { ...devices['Desktop Safari'] },
},

and npx playwright install --with-deps && npx playwright install chrome install these dependencies somewhere. I also had this settings before, but its removed with cimg/node:20.9.0 replacement. That limits us to use the latest version of Playwright.

@keita-determined keita-determined merged commit 88f64f6 into main Nov 28, 2023
69 of 80 checks passed
@keita-determined keita-determined deleted the chore/update-libraries branch November 28, 2023 19:34
@dannysauer dannysauer added this to the 0.26.5 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants