Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong skip experiment config regex for log policies #8475

Merged
merged 3 commits into from
Nov 27, 2023
Merged

fix: wrong skip experiment config regex for log policies #8475

merged 3 commits into from
Nov 27, 2023

Conversation

NicholasBlaskey
Copy link
Contributor

Description

Fix an issue where log_policies matched the experiment config line printed in trial logs. We had a check for this but the regex was based off an old version of the config.

Test Plan

e2e test covers this

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@NicholasBlaskey NicholasBlaskey requested a review from a team as a code owner November 27, 2023 15:06
@cla-bot cla-bot bot added the cla-signed label Nov 27, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 27, 2023 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit b8266f4
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6564b18bd3f6d10008f2c810

@determined-ci determined-ci requested a review from a team November 27, 2023 15:06
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Nov 27, 2023
jgongd
jgongd approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@jgongd jgongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@NicholasBlaskey NicholasBlaskey changed the title fix: wrong skip experiment config regex for log policies fix: wrong skip experiment config regex for log policies Nov 27, 2023
@NicholasBlaskey NicholasBlaskey enabled auto-merge (squash) November 27, 2023 15:11
@NicholasBlaskey NicholasBlaskey merged commit 64e299e into main Nov 27, 2023
65 of 79 checks passed
@NicholasBlaskey NicholasBlaskey deleted the log_policies_pattern branch November 27, 2023 15:29
@dannysauer dannysauer added this to the 0.26.5 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgongd jgongd jgongd approved these changes

Assignees
No one assigned
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.26.5
Development

Successfully merging this pull request may close these issues.
4 participants
@NicholasBlaskey @jgongd @dannysauer @determined-ci