Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add UpdateUsergroupMembership #8489

Merged
merged 5 commits into from
Nov 29, 2023
Merged

chore: add UpdateUsergroupMembership #8489

merged 5 commits into from
Nov 29, 2023

Conversation

carolinaecalderon
Copy link
Contributor

@carolinaecalderon carolinaecalderon commented Nov 28, 2023 •
edited
Loading

Description

For better code organization, adding this function to the usergroup module instead of EE oidc module. This method is used in EE oidc/service.go (and maybe saml/service.go).

Test Plan

added an intg test

Commentary (optional)

Should I unexport all the Tx functions now that UpdateUserGroupMembership is in the same module -- or leave as is?

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Nov 28, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 28, 2023 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 9d1c8e7
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/656747e660f5e60008fdc2be

@carolinaecalderon carolinaecalderon marked this pull request as ready for review November 28, 2023 18:56
@carolinaecalderon carolinaecalderon requested a review from a team as a code owner November 28, 2023 18:56
@carolinaecalderon carolinaecalderon changed the title Chore: add UpdateUsergroupMembership chore: add UpdateUsergroupMembership Nov 28, 2023
NicholasBlaskey
NicholasBlaskey approved these changes Nov 28, 2023
View reviewed changes
master/internal/usergroup/postgres_groups.go Show resolved Hide resolved
master/internal/usergroup/postgres_groups.go Outdated Show resolved Hide resolved
master/internal/usergroup/postgres_groups.go Outdated Show resolved Hide resolved
@carolinaecalderon carolinaecalderon merged commit 324f148 into main Nov 29, 2023
91 of 95 checks passed
@carolinaecalderon carolinaecalderon deleted the chore-update-usergroup-membership branch November 29, 2023 15:41
@dannysauer dannysauer added this to the 0.26.7 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasBlaskey NicholasBlaskey NicholasBlaskey approved these changes

@eecsliu eecsliu Awaiting requested review from eecsliu eecsliu is a code owner automatically assigned from determined-ai/backend

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
0.26.7
Development

Successfully merging this pull request may close these issues.
3 participants
@carolinaecalderon @NicholasBlaskey @dannysauer