feat: add the slots property to the props #8498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hkang1
reviewed
Dec 5, 2023
| nodes={agents.filter(({ resourcePools }) => resourcePools.includes(poolname))} | ||
| /> | ||
| )} | ||
| {!!topologyAgentPool.length && poolname && <Topology nodes={topologyAgentPool} />} |
There was a problem hiding this comment.
question: this looks better. I'm not too familiar here, but it's kind of odd that the ResourcepoolDetail.tsx doesn't make poolname required and is optional. Is there a case for the card to handle undefined value?
There was a problem hiding this comment.
I'm just following the type 😅 , I also think that it doesn't make much sense having it as undefined...
string | undefined
thiagodallacqua-hpe
force-pushed
the
thiago/topology-type-fix
branch
from
8330514
to
7f9c64b
Compare
hkang1
approved these changes
Dec 5, 2023
azhou-determined
added
the
to-cherry-pick
dai-release bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
(cherry picked from commit a6ae0c7)
azhou-determined
pushed a commit
that referenced
this pull request
Dec 7, 2023
(cherry picked from commit a6ae0c7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the
slotsproperty as a fallback option for rendering the node/agents slots and added a check for empty array in the context of the current RP filtering.Test Plan
Topologysection being rendered.Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket