Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix failing test_delete_experiment_removes_tensorboard_files #8511

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented Nov 30, 2023

Description

Fix failing test on main. Some other test sets the user in the token store to admin, since the test was running with a "different" cluster (aka not canonicalized so like 127.0.0.1:8080 vs http:127.0.0.1:8080) we think they are different clusters and have a different url.

Also moves this test to /cluster since backend owns experiment deletion.

This test is what likely messed with the token store (ran right before it)

api_utils.configure_token_store(conf.ADMIN_CREDENTIALS)

Test Plan

test passes

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Nov 30, 2023
Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit b0c2b28
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/656898d22782a10009a20a61

@NicholasBlaskey NicholasBlaskey merged commit 72ef508 into main Nov 30, 2023
74 of 86 checks passed
@NicholasBlaskey NicholasBlaskey deleted the fix_test_experiment_delete branch November 30, 2023 14:52
@dannysauer dannysauer added this to the 0.26.7 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants