Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enable multi-node testing [DET-3444] #852

Merged
merged 2 commits into from
Jul 14, 2020
Merged

ci: enable multi-node testing [DET-3444] #852

merged 2 commits into from
Jul 14, 2020

Conversation

shiyuann
Copy link
Contributor

@shiyuann shiyuann commented Jul 9, 2020 •
edited
Loading

Description

Enable multi node testing. Merge e2e GPU jobs in config.yml for circle CI.

Test Plan

Use the CI with the updated configuration to test if this works fine.

Commentary (optional)

N/A

@shiyuann shiyuann requested a review from brainhart July 9, 2020 00:03
@cla-bot cla-bot bot added the cla-signed label Jul 9, 2020
@shiyuann shiyuann force-pushed the ci-multi-node branch 4 times, most recently from ebeb5f6 to 22c620d Compare July 9, 2020 00:53
brainhart
brainhart reviewed Jul 10, 2020
View reviewed changes
Copy link
Contributor

@brainhart brainhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good 💯 -- I do think we should run GPU tests to verify this works as designed (and update the test plan)

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@brainhart brainhart assigned shiyuann and unassigned brainhart Jul 10, 2020
@shiyuann shiyuann assigned brainhart and unassigned shiyuann Jul 13, 2020
@brainhart brainhart assigned shiyuann and unassigned brainhart Jul 13, 2020
@brainhart
Copy link
Contributor

also please update the test plan :)

@shiyuann
Copy link
Contributor Author

@brain-good I updated the test plan to be using the CI. Is there any other way to test it?

@shiyuann shiyuann assigned brainhart and unassigned shiyuann Jul 13, 2020
@shiyuann
Copy link
Contributor Author

@brain-good Update: I added an argument cluster-id-prefix because the mark e2e_gpu cannot be used as a cluster id prefix.

@brainhart brainhart assigned shiyuann and unassigned brainhart Jul 14, 2020
@shiyuann shiyuann merged commit 84a914e into master Jul 14, 2020
@shiyuann shiyuann deleted the ci-multi-node branch July 14, 2020 20:00
@dannysauer dannysauer added this to the 0.12.12 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainhart brainhart brainhart approved these changes

Assignees

@shiyuann shiyuann

Labels
cla-signed
Projects
None yet
Milestone
0.12.12
Development

Successfully merging this pull request may close these issues.
3 participants
@shiyuann @brainhart @dannysauer