feat: Update the "Continue Single trial experiment" workflow #8526

julian-determined-ai · 2023-12-01T17:43:16Z

Description

Implements the "Continue Trial" workflow as described in WEB-1857

Test Plan

Navigate to an experiment list page.
Navigate to a completed experiment where the searcher is single.
Click "Continue Trial" and ensure you see a dropdown with the options "Create New Experiment..." and "Reactivate Current Trial..."
Click "Create New Experiment..." ensure the design and text match the Figma.
Click "Reactivate Current Trial..." ensure the design and text match the Figma.
Click "Create New Experiment..." ensure that the behavior matches the current "Continue Trial" flow (same modal as in step 1)
Click "Reactivate Current Trial..." .
Click "Show Full Config" and take note of the current "max_length"
Click "Show Simple Config" and input a positive number, check the full config again and make sure that the number was added to the "max_length"
Edit the "max_length" in the full config and click show simple config, ensure that the new additional value is equal to the (new max length - original config max length)
Edit the "max_length" in the full config to be an invalid value, for example a string, or float, or delete the max value entirely and click show simple config, ensure that the additional value field is blank.
In the simple config enter a valid value for "additional 'length' (this could be batches, epochs, or another unit)" and click "Reactivate Trial" ensure that the submissions is successful.
Navigate to an incomplete single trial experiment.
Click Continue Trial then "Reactivate Current Trial..." Ensure that the design matches the figma and you can only see the "full config" option and cannot switch to the simple config.
Click "Reactivate Trial" ensure that the submissions is successful.
Navigate to a completed experiment where the searcher is single. Ensure your screen size is large enough to see the "Continue Trial" button.
Click the overflow menu (the three vertical dots) ensure that you do not see "Create New Experiment" or "Reactivate Experiment".
Decrease your screen size until you cannot see the "Continue Trial Button" ensure that you can see "Create New Experiment" and "Reactivate Experiment"
Ensure you can only see the Continue Trial option for canceled, errored, completed, and/or deleted failed experiments.

Commentary (optional)

Checklist

Changes have been manually QA'd
User-facing API changes need the "User-facing API Change" label.
Release notes should be added as a separate file under docs/release-notes/.
See Release Note for details.
Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

WEB-1857

netlify · 2023-12-01T17:43:22Z

✅ Deploy Preview for determined-ui ready!

Name	Link
🔨 Latest commit	`91ead1b`
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/6578cea810b0790008361d90
😎 Deploy Preview	https://deploy-preview-8526--determined-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

gt2345

Do you think we can consolidate the Continue trial modal into the current Fork modal?

Some user experience comments:
When reactivating experiment, should we limit the parameters user can change in full config? For example, I can change workspace and project in full config, but the reactivated experiment should still be at the current project.
Should we allow continue/reactivate function when the experiment is running?

gt2345 · 2023-12-01T18:33:49Z

webui/react/src/components/PageHeaderFoldable.tsx

-            ))}
+            {options?.slice(0, 3).map((option) =>
+              option?.content ? (
+                option.content


This seems a bit hacky in my opinion, do you think there might be a way around it? Such as options?: (ButtonOption | DropdownOption)[]?

@gt2345 I could do that, I would then have to update several codepaths to handle either type which also felt a but hacky.

To me it seems a little weird to force us to only show a "Button" or "Dropdown" here. It seems possible that one day we might want to show an icon, or freeform text, or some other component here. I can do this but this seemed like a more future-proof approach.

@gt2345 I made several updates to this. We can now show any react node, and show multiple actions per react node, the latter was needed to show both of the actions in the button dropdown on the overflow list.

webui/react/src/components/ExperimentContinueModal.tsx

julian-determined-ai · 2023-12-01T20:25:12Z

When reactivating experiment, should we limit the parameters user can change in full config

@gt2345 I updated the UI to show an error if the Workspace or Project is changed

julian-determined-ai · 2023-12-05T17:56:05Z

Do you think we can consolidate the Continue trial modal into the current Fork modal?

Some user experience comments: When reactivating experiment, should we limit the parameters user can change in full config? For example, I can change workspace and project in full config, but the reactivated experiment should still be at the current project. Should we allow continue/reactivate function when the experiment is running?

@gt2345 for the last point I have updated this for only terminal states.

julian-determined-ai · 2023-12-05T18:01:44Z

@gt2345

Do you think we can consolidate the Continue trial modal into the current Fork modal

I actually started this work doing that at first. Ultimately, I ended up making a separate modal and just moved any shared functions to a util file. There is enough difference in the modals that I think trying to fit all of the differing functionality in one modal would result in a single overly complex component.

gt2345 · 2023-12-05T20:59:22Z

When reactivating experiment, should we limit the parameters user can change in full config

@gt2345 I updated the UI to show an error if the Workspace or Project is changed

Thanks for being open to it, but I think it might be best if we loop into backend to decide the full list of properties that cannot be modified with this continue action.
Also the message shows up when I change the workspace/project, but does not disappear when I change things back...

gt2345

Happy path works as expected, the thing I'm not sure is that could there be other config parameters that cannot be modified for continue action, and do we care that if the submitted config is inconsistent with the actual config?

gt2345 · 2023-12-05T20:49:49Z

webui/react/src/components/ExperimentContinueModal.tsx

+          </React.Suspense>
+        )}
+        {!isReactivate && !modalIsInAdvancedMode && (
+          <Body>Start a new experiment from the current trial&rsquo;s latest checkpoint.</Body>


This should be a grayish text color if possible according to design file

Theoretically yes we should have some validation (around what is a valid config) but I think we're ok to leave feature parity with the current continue feature since that is broader scope

Thanks @hkumar92 for clarification.
@julian-determined-ai Can we still address the style if possible?

webui/react/src/components/ExperimentContinueModal.tsx

webui/react/src/components/PageHeaderFoldable.tsx

julian-determined-ai · 2023-12-07T15:14:34Z

@gt2345

Also the message shows up when I change the workspace/project, but does not disappear when I change things back...

I cannot recreate this, can you give me steps to reproduce the issue>

CD429A40-5613-4B2A-AAD6-EF70E663E912.mov

gt2345 · 2023-12-07T18:22:28Z

@gt2345

Also the message shows up when I change the workspace/project, but does not disappear when I change things back...

I cannot recreate this, can you give me steps to reproduce the issue>

CD429A40-5613-4B2A-AAD6-EF70E663E912.mov

Interesting, I don't see anything we are doing differently... Also I suppose it's okay to remove this functionality based on what Haran said?

Screen.Recording.2023-12-07.at.12.17.29.PM.mov

gt2345 · 2023-12-12T17:53:25Z

Overall looks great, notices one unusual behavior. When the modal opens for the first time, the button should be disabled but not (which if fine), but when navigate to full config then navigate back, the additional batch field is auto filled. Is this by design?

Screen.Recording.2023-12-12.at.11.43.12.AM.mov

julian-determined-ai · 2023-12-12T18:02:29Z

Overall looks great, notices one unusual behavior. When the modal opens for the first time, the button should be disabled but not (which if fine), but when navigate to full config then navigate back, the additional batch field is auto filled. Is this by design?

Screen.Recording.2023-12-12.at.11.43.12.AM.mov

@gt2345 this is actually by design and as intended. I agree that the behavior is a bit awkward. I think re-visiting this when/if we decide to change how we validate changes in the full config makes sense though.

gt2345

LGTM

julian-determined-ai added 11 commits November 29, 2023 15:52

feat: Update the Continue Single trial experiment workflow

08184d3

Merge branch 'main' into web-1857

114bee8

created continue experiment modal

c1b281a

implement all functionality

76058a5

fix errors

d6fcfe3

several fixes

c5b458d

implement page reload

eb9f59f

slight refactor

a919e5f

move shared methods to utils

16cf7af

fix test cases

1fea266

copy update

5300232

julian-determined-ai requested a review from a team as a code owner December 1, 2023 17:43

julian-determined-ai requested a review from gt2345 December 1, 2023 17:43

cla-bot bot added the cla-signed label Dec 1, 2023

julian-determined-ai assigned gt2345 Dec 1, 2023

gt2345 reviewed Dec 1, 2023

View reviewed changes

julian-determined-ai added 3 commits December 1, 2023 12:52

use hew input number

4f3a1ac

merge main

c2cf4b7

show error when trying to change project or workspace

e202324

julian-determined-ai added 3 commits December 4, 2023 12:14

refactor option to React Node

66f36bb

refactor ActionOptions

bbc208d

add state check

4b61671

julian-determined-ai requested a review from gt2345 December 5, 2023 17:54

julian-determined-ai requested review from alexjdetermined and hkumar92 December 5, 2023 18:02

formatting

fd9cdb5

julian-determined-ai added 5 commits December 5, 2023 12:29

formatting

f034c54

formatting

9abc8b3

formatting

7d9a53b

formatting

ca4cfb5

formatting

3341f3c

gt2345 reviewed Dec 5, 2023

View reviewed changes

webui/react/src/components/PageHeaderFoldable.tsx Show resolved Hide resolved

julian-determined-ai added 4 commits December 5, 2023 15:12

remove unused content

f420451

Merge branch 'main' into web-1857

bb509cb

restore Antd and Hew buttons

7ca56ec

default max length to batches

a84dede

remove workspace and project error

d5ce13c

julian-determined-ai force-pushed the web-1857 branch from 8e2b9a2 to d5ce13c Compare December 8, 2023 16:51

julian-determined-ai requested a review from gt2345 December 12, 2023 15:55

gt2345 approved these changes Dec 12, 2023

View reviewed changes

julian-determined-ai added 6 commits December 12, 2023 14:32

Merge branch 'main' into web-1857

8b7b1d6

trying foramtting fix

17f2a7f

trying foramtting fix

211f85e

trying foramtting fix

2002911

trying formatting fix

a63e817

trying formatting fix

91ead1b

julian-determined-ai enabled auto-merge (squash) December 12, 2023 21:20

julian-determined-ai merged commit 660de26 into main Dec 12, 2023
65 of 77 checks passed

julian-determined-ai deleted the web-1857 branch December 12, 2023 21:26

dannysauer added this to the 0.26.7 milestone Feb 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Update the "Continue Single trial experiment" workflow #8526

feat: Update the "Continue Single trial experiment" workflow #8526

julian-determined-ai commented Dec 1, 2023 •

edited

Loading

netlify bot commented Dec 1, 2023 •

edited

Loading

gt2345 left a comment

gt2345 Dec 1, 2023

julian-determined-ai Dec 1, 2023

julian-determined-ai Dec 5, 2023

julian-determined-ai commented Dec 1, 2023

julian-determined-ai commented Dec 5, 2023

julian-determined-ai commented Dec 5, 2023 •

edited

Loading

gt2345 commented Dec 5, 2023

gt2345 left a comment

gt2345 Dec 5, 2023

hkumar92 Dec 5, 2023

gt2345 Dec 12, 2023

julian-determined-ai commented Dec 7, 2023 •

edited

Loading

gt2345 commented Dec 7, 2023

gt2345 commented Dec 12, 2023

julian-determined-ai commented Dec 12, 2023

gt2345 left a comment

feat: Update the "Continue Single trial experiment" workflow #8526

feat: Update the "Continue Single trial experiment" workflow #8526

Conversation

julian-determined-ai commented Dec 1, 2023 • edited Loading

Description

Test Plan

Commentary (optional)

Checklist

Ticket

netlify bot commented Dec 1, 2023 • edited Loading

✅ Deploy Preview for determined-ui ready!

gt2345 left a comment

Choose a reason for hiding this comment

gt2345 Dec 1, 2023

Choose a reason for hiding this comment

julian-determined-ai Dec 1, 2023

Choose a reason for hiding this comment

julian-determined-ai Dec 5, 2023

Choose a reason for hiding this comment

julian-determined-ai commented Dec 1, 2023

julian-determined-ai commented Dec 5, 2023

julian-determined-ai commented Dec 5, 2023 • edited Loading

gt2345 commented Dec 5, 2023

gt2345 left a comment

Choose a reason for hiding this comment

gt2345 Dec 5, 2023

Choose a reason for hiding this comment

hkumar92 Dec 5, 2023

Choose a reason for hiding this comment

gt2345 Dec 12, 2023

Choose a reason for hiding this comment

julian-determined-ai commented Dec 7, 2023 • edited Loading

gt2345 commented Dec 7, 2023

gt2345 commented Dec 12, 2023

julian-determined-ai commented Dec 12, 2023

gt2345 left a comment

Choose a reason for hiding this comment

julian-determined-ai commented Dec 1, 2023 •

edited

Loading

netlify bot commented Dec 1, 2023 •

edited

Loading

julian-determined-ai commented Dec 5, 2023 •

edited

Loading

julian-determined-ai commented Dec 7, 2023 •

edited

Loading