chore: remove --dry-run option from det deploy aws [MLG-983] #8542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tara-det-ai
reviewed
Dec 7, 2023
| **Breaking Changes** | ||
|
|
||
| - CLI: The `--dry-run` option for `det deploy aws` has been removed. Previously, this option had no | ||
| effect, as AWS CloudFormation does not provide a utility to preview staged changes. |
There was a problem hiding this comment.
Breaking Changes
- CLI: Remove the
--dry-runoption fordet deploy aws. This option has no effect because AWS CloudFormation does not provide a utility to preview staged changes.
tara-det-ai
approved these changes
Dec 7, 2023
ioga
approved these changes
Dec 7, 2023
| @@ -0,0 +1,4 @@ | |||
| **Breaking Changes** | |||
|
|
|||
| - CLI: The `--dry-run` option for `det deploy aws` has been removed. Previously, this option had no | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original ticket was brought up by user attempting to set
--no-shut-down-agents-on-connection-lossand not seeing--dry-runoption populated. AFAICT,--no-shut-down-agents-on-connection-lossis correctly populated in the AWS templates and functions as expected.Per slack discussions, we are removing
--dry-runbecause it currently has no effect and AWS CloudFormation doesn't surface a way to "preview" deploy before deploying.Test Plan
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket