fix: use TF Tensorboard writer by default [DET-3353] #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidneyw
approved these changes
Jul 9, 2020
| @@ -174,15 +174,14 @@ def _scan_checkpoint_directory(checkpoint_dir: str) -> List[Checkpoint]: | |||
| return list(checkpoints.values()) | |||
|
|
|||
|
|
|||
| def move_tf_events(root_dir: str) -> None: | |||
| def move_tf_events(event_dir: pathlib.Path) -> None: | |||
| @@ -147,15 +147,15 @@ def prepare_tensorboard( | |||
| env, env.experiment_config["checkpoint_storage"], container_path | |||
| ) | |||
| try: | |||
| from determined.tensorboard.metric_writers import pytorch | |||
| from determined.tensorboard.metric_writers import tensorflow | |||
There was a problem hiding this comment.
non-blocking: as mentioned just make sure that this works well in containers without tensorflow installed.
There was a problem hiding this comment.
Checked and it works 🥳
eecsliu
pushed a commit
to eecsliu/determined
that referenced
this pull request
Jun 23, 2023
If a dispatch suddenly disappeared from the luancher (404) without any action monitoring was dropped without any notification of job completion. On 404, notify that the job was lost and terminate.
stoksc
pushed a commit
that referenced
this pull request
Jun 26, 2023
If a dispatch suddenly disappeared from the luancher (404) without any action monitoring was dropped without any notification of job completion. On 404, notify that the job was lost and terminate.
eecsliu
pushed a commit
that referenced
this pull request
Jun 28, 2023
If a dispatch suddenly disappeared from the luancher (404) without any action monitoring was dropped without any notification of job completion. On 404, notify that the job was lost and terminate.
eecsliu
pushed a commit
that referenced
this pull request
Jun 28, 2023
If a dispatch suddenly disappeared from the luancher (404) without any action monitoring was dropped without any notification of job completion. On 404, notify that the job was lost and terminate.
stoksc
pushed a commit
that referenced
this pull request
Jul 20, 2023
If a dispatch suddenly disappeared from the luancher (404) without any action monitoring was dropped without any notification of job completion. On 404, notify that the job was lost and terminate.
eecsliu
pushed a commit
that referenced
this pull request
Jul 24, 2023
If a dispatch suddenly disappeared from the luancher (404) without any action monitoring was dropped without any notification of job completion. On 404, notify that the job was lost and terminate.
stoksc
pushed a commit
that referenced
this pull request
Oct 17, 2023
If a dispatch suddenly disappeared from the luancher (404) without any action monitoring was dropped without any notification of job completion. On 404, notify that the job was lost and terminate.
azhou-determined
pushed a commit
that referenced
this pull request
Dec 7, 2023
If a dispatch suddenly disappeared from the luancher (404) without any action monitoring was dropped without any notification of job completion. On 404, notify that the job was lost and terminate.
wes-turner
pushed a commit
that referenced
this pull request
Feb 2, 2024
If a dispatch suddenly disappeared from the luancher (404) without any action monitoring was dropped without any notification of job completion. On 404, notify that the job was lost and terminate.
rb-determined-ai
pushed a commit
that referenced
this pull request
Feb 29, 2024
If a dispatch suddenly disappeared from the luancher (404) without any action monitoring was dropped without any notification of job completion. On 404, notify that the job was lost and terminate.
amandavialva01
pushed a commit
that referenced
this pull request
Mar 18, 2024
If a dispatch suddenly disappeared from the luancher (404) without any action monitoring was dropped without any notification of job completion. On 404, notify that the job was lost and terminate.
eecsliu
pushed a commit
that referenced
this pull request
Apr 18, 2024
If a dispatch suddenly disappeared from the luancher (404) without any action monitoring was dropped without any notification of job completion. On 404, notify that the job was lost and terminate.
eecsliu
pushed a commit
to determined-ai/determined-release-testing
that referenced
this pull request
Apr 22, 2024
If a dispatch suddenly disappeared from the luancher (404) without any action monitoring was dropped without any notification of job completion. On 404, notify that the job was lost and terminate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It appears that using the PyTorch TensorBoard writer lead to TF events coming out in a "strange" state.
Test Plan
Ran several experiments and observed that file naming changed from always having a file ending
1.0to not having it, this file seemed to have been the cause of some of the issues.Going to test this out with a container that doesn't have TF.