chore: Change CLI and constants #8593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
szewaiyuen6
changed the title
hamidzr
reviewed
Dec 14, 2023
There was a problem hiding this comment.
thanks for working on this.
leaving the internal references to lore as lore for as a separate tasks sgtm but I think we should at least migration all the lore.?version references together in this pr otherwise it'd be hard to track
(determined) hbp ➜ determined git:(update_deploy_2) ag 'lore.?version'
harness/determined/deploy/aws/deployment_types/vpc.py
49: lore_tag = self.parameters[constants.cloudformation.LORE_VERSION] or "latest"
harness/determined/deploy/aws/constants.py
78: LORE_VERSION = "LoreVersion"
harness/determined/deploy/aws/cli.py
270: constants.cloudformation.LORE_VERSION: args.genai_version,
harness/determined/deploy/aws/templates/lore.yaml
219: LoreVersion:
221: Description: Lore version to deploy
294: {{ if ne .lore_version "" }}
922: lore_version: ${LoreVersion}
974: if [ ! -z "${LoreVersion}" ]; then
983: --env LORE_DOCKER_TAG_SUFFIX="${LoreVersion}" \
987: "determinedai/environments-dev:lore-backend-image-${LoreVersion}"
harness/determined/deploy/aws/deployment_types/base.py
45: constants.cloudformation.LORE_VERSION,
harness/determined/deploy/aws/templates/fsx.yaml
289: {{ if ne .lore_version "" }}
harness/determined/deploy/aws/templates/simple.yaml
280: {{ if ne .lore_version "" }}
harness/determined/deploy/aws/templates/efs.yaml
289: {{ if ne .lore_version "" }}
harness/determined/deploy/aws/templates/govcloud.yaml
234: {{ if ne .lore_version "" }}
harness/determined/deploy/aws/templates/simple-rds.yaml
288: {{ if ne .lore_version "" }}
harness/determined/deploy/aws/templates/secure.yaml
284: {{ if ne .lore_version "" }}
harness/determined/deploy/aws/injector/master.yaml.tmpl
60:{{ if ne .lore_version "" }}
(determined) hbp ➜ determined git:(update_deploy_2)
hamidzr
approved these changes
Dec 14, 2023
| @@ -42,10 +42,12 @@ class EFS(VPCBase): | |||
|
|
|||
| class Lore(VPCBase): | |||
There was a problem hiding this comment.
should this classname be changed too?
There was a problem hiding this comment.
This is an internal reference, we are doing the naming migration in phases and focusing on user facing noes first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change user-facing parts of the det deploy that references lore to genai.
Internal references clean up will be a separate task (lower pri).
Test Plan
det deploy aws up --cluster-id swy-lore-test4 --region us-west-2 --keypair szewai-determined-aws --compute-agent-instance-type g4dn.12xlarge --max-dynamic-agents 10 --det-v 115f685a4cd4025118a198751a81b5e0105c5f68 --max-idle-agent-period 60m --deployment-type genai --genai-version a45d508Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket