chore: cli describe workspaces no longer also lists projects #8609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Old: `det workspace describe <workspace>` (when executed with out `--json`) used to first print a table of information about the passed workspace and then would print another table listing all the projects that belong to the workspace. New: `det workspace describe <workspace>` *only* describes the passed workspace Justification: `det workspace list-projects <workspace>` is already a thing. If a user wants to list workspaces they can run that command. The old behavior was awkward to implement because it needed to assume parameters to list-projects that would normally be passed as flags to `det workspace -list-projects`.
wes-turner
force-pushed
the
wes/cli-desc-workspace-no-list-project
branch
from
21319d0
to
9d39966
Compare
daranday
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old:
det workspace describe <workspace>(when executed with out--json) used to first print a table of information about the passed workspace and then would print another table listing all the projects that belong to the workspace.New:
det workspace describe <workspace>only describes the passed workspaceJustification:
det workspace list-projects <workspace>is already a thing. If a user wants to list workspaces they can run that command. The old behavior was awkward to implement because it needed to assume parameters to list-projects that would normally be passed as flags todet workspace list-projects.MLG-1113
Description
Test Plan
Describe a workspace:
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket