Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: model versions sdk and CLI [DET-3477] [DET-3480] #861

Merged
merged 4 commits into from
Jul 10, 2020

Conversation

sidneyw
Copy link
Contributor

@sidneyw sidneyw commented Jul 10, 2020

Description

Adds python and CLI methods for creating and querying model versions.

Test Plan

Added integration tests to cover new functionality.

@sidneyw sidneyw requested a review from ybt195 July 10, 2020 03:34
@cla-bot cla-bot bot added the cla-signed label Jul 10, 2020
@sidneyw sidneyw changed the title Feat/versions sdk feat: model versions sdk and CLI Jul 10, 2020
@sidneyw sidneyw marked this pull request as ready for review July 10, 2020 14:49
// The list of returned model versions
repeated determined.model.v1.ModelVersion versions = 1;
// The model requested.
determined.model.v1.Model model = 1;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: I like the use of the top-level response.

master=master,
)
@staticmethod
def from_json(data: Dict[str, Any], master: Optional[str] = None) -> "Checkpoint":
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: this API looks much more concise.

@ybt195 ybt195 assigned sidneyw and unassigned ybt195 Jul 10, 2020
@sidneyw sidneyw changed the title feat: model versions sdk and CLI feat: model versions sdk and CLI [DET-3477] [DET-3480] Jul 10, 2020
@sidneyw sidneyw merged commit 394e317 into determined-ai:master Jul 10, 2020
@sidneyw sidneyw deleted the feat/versions-sdk branch July 10, 2020 15:50
eecsliu pushed a commit to eecsliu/determined that referenced this pull request Jun 23, 2023
stoksc pushed a commit that referenced this pull request Jun 26, 2023
stoksc pushed a commit that referenced this pull request Jul 20, 2023
stoksc pushed a commit that referenced this pull request Oct 17, 2023
@dannysauer dannysauer added this to the 0.12.12 milestone Feb 6, 2024
eecsliu pushed a commit to determined-ai/determined-release-testing that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants