Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update experiment hp search param quoting #8620

Merged
merged 1 commit into from
Dec 27, 2023
Merged

fix: update experiment hp search param quoting #8620

merged 1 commit into from
Dec 27, 2023

Conversation

erikwilson
Copy link
Contributor

@erikwilson erikwilson commented Dec 21, 2023 •
edited
Loading

Description

Update for experiment hyper-parameter search to remove extra quotes.

Test Plan

Automated.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

DET-9799

@erikwilson erikwilson requested a review from a team as a code owner December 21, 2023 21:19
@cla-bot cla-bot bot added the cla-signed label Dec 21, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 21, 2023 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 53ad6e3
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/658c4fc25cc76300083579e2

@erikwilson erikwilson changed the title fix: update experiment hp search to use placeholders fix: update experiment hp search param quoting Dec 27, 2023
hamidzr
hamidzr approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@hamidzr hamidzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

the web ui around sorting and filtering probably needs an update as well. it should somehow communicate that something went wront to the user instead it seems to just staying in the loading state.

Screenshot 2023-12-27 at 09 56 01

@erikwilson erikwilson merged commit fac9fa0 into main Dec 27, 2023
70 of 81 checks passed
@erikwilson erikwilson deleted the fix/exp-search-orderby branch December 27, 2023 18:47
@dannysauer dannysauer added this to the 0.27.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamidzr hamidzr hamidzr approved these changes

@AmanuelAaron AmanuelAaron Awaiting requested review from AmanuelAaron AmanuelAaron is a code owner automatically assigned from determined-ai/backend

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@erikwilson @hamidzr @dannysauer