Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete unused experiment fields #8639

Merged
merged 7 commits into from
Jan 8, 2024

Conversation

carolinaecalderon
Copy link
Contributor

@carolinaecalderon carolinaecalderon commented Jan 4, 2024

Description

Delete unused fields from the experiment table.

Test Plan

Pass existing db intg tests.
To manually test, spin up a devcluster & check that the db (psql -h localhost -p 5432 -U postgres -d postgres) does not have "git_*" or "model_packages" columns in the experiment table

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

DET-10034

@cla-bot cla-bot bot added the cla-signed label Jan 4, 2024
Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 90e8020
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65984022088139000822f59d

Copy link
Contributor

@corban-beaird corban-beaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

Copy link
Contributor

@hkang1 hkang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think web isn't consuming it at all as far as I can tell (did a quick repo search) so the web portion should be good to go!

@carolinaecalderon carolinaecalderon merged commit 926a6de into main Jan 8, 2024
75 of 86 checks passed
@carolinaecalderon carolinaecalderon deleted the 10034-delete-exp-fields branch January 8, 2024 19:47
@dannysauer dannysauer modified the milestone: 0.27.1 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants